Fix issue with query string parsing #111
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This issue was leading to incorrect message digests which led to a 403 forbidden error. The query parameter 'fields' needed to be decoded before use. Otherwise, it would be encoded twice somewhere inside the request.META.get (i think -unconfirmed) i.e ,(comma) -> %2C -> %252C This extra encoding caused the message digests to mismatch leading to the 403 error.
jacobtoppm
requested changes
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue was leading to incorrect message digests which led to a 403
forbidden error.
The query parameter 'fields' needed to be decoded before use. Otherwise,
it would be encoded twice somewhere inside the request.META.get
(i think -unconfirmed)
i.e
,(comma) -> %2C -> %252C
This extra encoding caused the message digests to mismatch leading to
the 403 error.
Willing to write test coverage and help implement an alternative fix approach if requested.
Django 4.0.3
Python 3.8
Wagtail 2.16.1